ThumbnailWrite method with storing the JpegSegments offset#353
Open
Gorbush wants to merge 2 commits intodrewnoakes:mainfrom
Open
ThumbnailWrite method with storing the JpegSegments offset#353Gorbush wants to merge 2 commits intodrewnoakes:mainfrom
Gorbush wants to merge 2 commits intodrewnoakes:mainfrom
Conversation
Author
|
Hi, Any comments on this? |
|
Any plans to integrate this PR? We can not upgrade the library because we need thumbnail extraction too, that method removal was a breaking change without pointing to alternative ways of getting the old functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-implements the method to write the Thumbnail into file without loading the bytes into memory during each image parsing.
I still need to extract thumbnails, and after removal of this method from ExifThumbnailDirectory - it is impossible, as offset is stored relative to the segment data, and reader with segment data is not available at that time.
This change is storing the offset of the segment in the root directory, so ti is possible to calculate the real thumbnail offset in the file ad hoc.