Delete heavyweight internal testing classes (#303)

Use private fields instead, which are set in tests using reflection.

Author: drewhamilton

datetimeformatters/src/androidTest/java/dev/drewhamilton/androidtime/format/test/TimeSettingTest.kt

@@ -8,10 +8,9 @@ import android.provider.Settings
 import androidx.core.os.ConfigurationCompat
 import androidx.core.os.LocaleListCompat
 import androidx.test.platform.app.InstrumentationRegistry
-import dev.drewhamilton.androidtime.format.TestSystemTimeSetting
-import dev.drewhamilton.androidtime.format.testSystemTimeSetting
+import dev.drewhamilton.androidtime.format.AndroidDateTimeFormatter
 import java.util.Locale
-import org.junit.After
+import org.junit.Before
 
 /**
  * A base test class that facilitates using and changing [testSystemTimeSetting], which mimics the
@@ -31,12 +30,9 @@ abstract class TimeSettingTest {
         }
 
     protected var systemTimeSetting: String?
-        get() = when (val testSystemTimeSetting = testSystemTimeSetting) {
-            is TestSystemTimeSetting.Set -> testSystemTimeSetting.value
-            is TestSystemTimeSetting.Unset -> null
-        }
+        get() = AndroidDateTimeFormatter.testSystemTimeSetting
         set(value) {
-            testSystemTimeSetting = TestSystemTimeSetting.Set(value)
+            AndroidDateTimeFormatter.testSystemTimeSetting = value
         }
 
     private fun Context.copyWithLocale(locale: Locale): Context {
@@ -55,10 +51,34 @@ abstract class TimeSettingTest {
             locale = locales[0]
     }
 
-    @After fun restoreTimeSetting() {
-        testSystemTimeSetting = TestSystemTimeSetting.Unset
+    @Before fun enableTestSystemTimeSetting() {
+        AndroidDateTimeFormatter.useTestSystemTimeSetting = true
     }
 
+    private var AndroidDateTimeFormatter.useTestSystemTimeSetting: Boolean
+        get() = javaClass.declaredFields
+            .single { it.name == "useTestSystemTimeSetting" }
+            .apply { isAccessible = true }
+            .get(this) as Boolean
+        set(value) {
+            javaClass.declaredFields
+                .single { it.name == "useTestSystemTimeSetting" }
+                .apply { isAccessible = true }
+                .set(this, value)
+        }
+
+    private var AndroidDateTimeFormatter.testSystemTimeSetting: String?
+        get() = javaClass.declaredFields
+            .single { it.name == "testSystemTimeSetting" }
+            .apply { isAccessible = true }
+            .get(this) as String?
+        set(value) {
+            javaClass.declaredFields
+                .single { it.name == "testSystemTimeSetting" }
+                .apply { isAccessible = true }
+                .set(this, value)
+        }
+
     protected companion object {
         const val TIME_SETTING_12 = "12"
         const val TIME_SETTING_24 = "24"

datetimeformatters/src/main/java/dev/drewhamilton/androidtime/format/AndroidDateTimeFormatter.kt

@@ -349,17 +349,11 @@ object AndroidDateTimeFormatter {
     }
 
     @JvmStatic private fun Context.timeSetting(): String? {
-        // TODO: Support testing without a static field?
-        return when (val testSystemTimeSetting = testSystemTimeSetting) {
+        return if (useTestSystemTimeSetting) {
+            testSystemTimeSetting
+        } else {
             // Prod code path:
-            is TestSystemTimeSetting.Unset -> {
-                Settings.System.getString(contentResolver, Settings.System.TIME_12_24)
-            }
-
-            // Test code path:
-            is TestSystemTimeSetting.Set -> {
-                testSystemTimeSetting.value
-            }
+            Settings.System.getString(contentResolver, Settings.System.TIME_12_24)
         }
     }
 
@@ -498,4 +492,9 @@ object AndroidDateTimeFormatter {
         }
         return locale!!
     }
+
+    //region Test
+    private var useTestSystemTimeSetting: Boolean = false
+    private var testSystemTimeSetting: String? = null
+    //endregion
 }