This repository was archived by the owner on Oct 30, 2025. It is now read-only.
destroy后不刷新页面重新create传入新的列数时会创建旧列数的表#1390
Open
xieranmaya wants to merge 2 commits intodream-num:masterfrom
Open
destroy后不刷新页面重新create传入新的列数时会创建旧列数的表#1390xieranmaya wants to merge 2 commits intodream-num:masterfrom
xieranmaya wants to merge 2 commits intodream-num:masterfrom
Conversation
修复bug:destroy后不刷新页面重新create时,即使传入新的column字段,表格的大小也还是原来设定的值,原因在于create时Store从defaultSettings中读取了对象,而后续又经由Store对该对象进行了修改,导致对该对象的修改直接修改到了defaultSettings里面,而destroy时并没有把defaultSettings还原,只还原了Store等其它对象。本pr在合并defaultSettings时先将其尝试克隆一遍以防止其被修改到,做为defaultSettings,应该是只读的。
Update core.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复bug:destroy后不刷新页面重新create时,即使传入新的column字段,表格的大小也还是第一次createe时设定的值,原因在于create时Store从defaultSettings中读取了对象,而后续又经由Store对该对象进行了修改,导致对该对象的修改直接修改到了defaultSettings里面(毕竟defaultSettings不是一个扁平的对象),而destroy时并没有把defaultSettings还原,只还原了Store等其它对象。做为defaultSettings,应该是只读的,所以本pr在合并defaultSettings时先将其深度克隆一遍以防止其被修改,就可以防止第二次create时用到上一次的数据了。