Ignore blur event inside the open menu #1648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen on iOS. If the select is opened a blur event is fired immediately. Possibly fixes downshift-js#443.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen on iOS. If the select is opened a blur event is fired immediately.
What:
This patch fixes a bug where the select would immediately close again on iOS Safari.
Possible fix for #443.
Why:
Safari on iOS could trigger a blur event immediately after the dropdown was opened.
How:
There is now a check that verifies that when an input blur event is received, the active element is not inside the menu since this would close the menu.
Checklist:
We originally patched this locally in version 6 and this has been in production for years together with the changes for #1647.