fix(type): Nullable setHighlightedIndex#1559
Open
miya wants to merge 3 commits intodownshift-js:masterfrom
Open
fix(type): Nullable setHighlightedIndex#1559miya wants to merge 3 commits intodownshift-js:masterfrom
miya wants to merge 3 commits intodownshift-js:masterfrom
Conversation
Collaborator
|
Why |
Author
|
Indeed, I think using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Changed the argument (index) of
setHighlightedIndexfrom number to number | null.Why:
The implementation is supposed to allow null, but the interface did not accept null. Also it seems that a pull request implementing an approach that respects null, as also mentioned in #66 has been merged
How:
I've only made corrections to the interface.
Checklist: