Fix insecure atoi usage#121
Open
slusarz wants to merge 2 commits intodovecot:mainfrom
Open
Conversation
Replaced insecure atoi usage with str_to_uint() when parsing IMAP tagged replies.
sirainen
requested changes
May 6, 2026
| str_to_uint(t_strcut(p+1, ' '), &tag_id) == 0) | ||
| cmd = command_lookup(client, tag_id); | ||
|
|
||
| if (cmd == NULL) |
| command_lookup(client, atoi(t_strcut(p+1, ' '))) : NULL; | ||
| if (cmd == NULL) { | ||
| if (p != NULL && | ||
| str_to_uint(t_strdup_until(tag, p), &global_id) == 0 && |
Contributor
There was a problem hiding this comment.
Since there's already a different complaint: Don't say atoi() is insecure in commit message. This change is nice enough, but makes practically no difference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert to Dovecot str_to_uint() instead.