imap-parser-nesting-limit#282
Closed
uwezkhan wants to merge 2 commits intodovecot:mainfrom
Closed
Conversation
Contributor
|
fixed with 9a0f8c1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IMAP parser currently tracks list_count_limit, but nested list depth is only constrained after lists are closed. This means deeply nested input can still build a large recursive imap_arg tree before the limit is enforced.
Several downstream imap_arg consumers traverse these structures recursively, so excessively deep nesting may lead to stack exhaustion.
This change adds proactive nesting-depth enforcement when opening lists by:
The hard ceiling is intentionally conservative and aligns with similar nesting limits elsewhere in the codebase.
Tests are included for both: