Remove unused dead code in BamlMapTable / XamlTypeMapper#10881
Open
h3xds1nz wants to merge 4 commits intodotnet:mainfrom
Open
Remove unused dead code in BamlMapTable / XamlTypeMapper#10881h3xds1nz wants to merge 4 commits intodotnet:mainfrom
h3xds1nz wants to merge 4 commits intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
requested review from
Kuldeep-MS,
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
34 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10881 +/- ##
===================================================
- Coverage 13.48885% 2.98889% -10.49996%
===================================================
Files 3317 3319 +2
Lines 664749 664729 -20
Branches 74643 74649 +6
===================================================
- Hits 89667 19868 -69799
- Misses 572488 644680 +72192
+ Partials 2594 181 -2413
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows #10636 which removes the uncalled
Initializemethod (here I just remove one of the called methods inside).Description
Removes unused code since
NetFX4inBamlMapTable/XamlTypeMapper.They're independent of each other actually but the removal makes sense to do together.
Customer Impact
Smaller assembly size, cleaner codebase for developers.
Regression
No.
Testing
Local build.
Risk
Low, unused dead code.
Microsoft Reviewers: Open in CodeFlow