[release/10.0.3xx] Source code updates from dotnet/dotnet#9818
Conversation
| ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| name: $[replace(replace(eq(contains(coalesce(variables['System.PullRequest.TargetBranch'], variables['Build.SourceBranch'], 'refs/heads/main'), 'release'), 'true'), True, 'NetCore1ESPool-Svc-Internal'), False, 'NetCore1ESPool-Internal')] | ||
| image: Azure-Linux-3-Amd64 | ||
| image: 1es-mariner-2 |
There was a problem hiding this comment.
@MiYanni does arcade build 10.0.0-beta.26103.116 have the change you were looking for based on #9754 (comment)
There was a problem hiding this comment.
Lol. The value has actually changed again:
It originally was 1es-mariner-2, but that caused the CI build to break after Jan 1st. Then, Sean changed it to Azure-Linux-3-Amd64 locally in templating here to work around the build break. Michael changed it to Azure-Linux-3-Amd64 in Arcade 10, and that's why we shouldn't expect this line to change. But now, it has been changed again to build.azurelinux.3.amd64: https://github.com/dotnet/arcade/blob/release/10.0/eng/common/core-templates/job/source-build.yml#L66
Looks like Alexander changed it 2 hours ago: dotnet/arcade@58d7536
There was a problem hiding this comment.
lol yeah dnceng took some time to settle on a name :D the next VMR codeflow should have the update to build.azurelinux.3.amd64
There was a problem hiding this comment.
I see you manually changed it. I've been waiting a couple weeks for this value to update from the VMR. I don't understand why this PR from the VMR wouldn't have the right value (or even the previous value) at this point. It still had the original value when the PR was created 4 days ago.
There was a problem hiding this comment.
It's still wrong in the VMR - https://github.com/dotnet/dotnet/blob/854a5cae4c3fbf9530e875f840fb475809557c8e/src/templating/eng/common/core-templates/job/source-build.yml#L66C22-L66C37
Do we want to update that in the VMR or let this flow through? This PR itself seems good to me now.
There was a problem hiding this comment.
@MiYanni you're right, while looking at this I noticed that there was no arcade->VMR subscription for release/10.0.3xx so it had a very old arcade, this is fixed now and I also told Matt since this should've been created by the branching tool
There was a problem hiding this comment.
@akoeplinger Omg, thank you so much! I didn't understand what was happening. I generally don't dig into DARC flows. Really looking forward to the file-based flow mechanism.
| ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| name: $[replace(replace(eq(contains(coalesce(variables['System.PullRequest.TargetBranch'], variables['Build.SourceBranch'], 'refs/heads/main'), 'release'), 'true'), True, 'NetCore1ESPool-Svc-Internal'), False, 'NetCore1ESPool-Internal')] | ||
| image: Azure-Linux-3-Amd64 | ||
| image: 1es-mariner-2 |
There was a problem hiding this comment.
Lol. The value has actually changed again:
It originally was 1es-mariner-2, but that caused the CI build to break after Jan 1st. Then, Sean changed it to Azure-Linux-3-Amd64 locally in templating here to work around the build break. Michael changed it to Azure-Linux-3-Amd64 in Arcade 10, and that's why we shouldn't expect this line to change. But now, it has been changed again to build.azurelinux.3.amd64: https://github.com/dotnet/arcade/blob/release/10.0/eng/common/core-templates/job/source-build.yml#L66
Looks like Alexander changed it 2 hours ago: dotnet/arcade@58d7536
dotnet-maestro
bot
deleted the
darc-release/10.0.3xx-be69d88a-b2cf-4cda-b5b6-c77e20d6bae1
branch
4 participants
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos
Diff the source with this PR branch