Update copilot instructions with baseline setup details #123064
Closed
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since removing the build setup step, copilot is being lazy about doing the baseline setup. Try to coax it to do it more aggressively.
Member
Author
|
/ba-g markdown only |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an explicit instruction to the copilot instructions file to emphasize that baseline setup must be completed before building and testing. The goal is to ensure copilot performs the prerequisite build steps more consistently.
Changes:
- Added a MUST requirement to handle baseline setup before building/testing, with a specific example for libraries workflow
Emphasize the importance of completing the baseline setup before building and testing code changes, including a note on the time required.
jkotas
reviewed
Jan 10, 2026
|
|
||
| If you make code changes, do not complete without checking the relevant code builds and relevant tests still pass after the last edits you make. Do not simply assume that your changes fix test failures you see, actually build and run those tests again to confirm. You can avoid building if you only change comments or files that do not affect builds and tests (e.g. README.md). | ||
|
|
||
| **In order to successfully build and run tests, you MUST first handle the baseline setup (see "1.2. Baseline Setup"), e.g. before you can build/test libraries, you must run `./build.sh clr+libs -rc release` at least once. This could take upwards of 10-20 minutes. You MUST wait for it to complete. You MUST not skip this step if you're making _any_ non-comment code changes.** |
Member
There was a problem hiding this comment.
./build.sh clr+libs -rc release
This is libraries workflow specific. Would it work better if this emphasis is in "1.2. Baseline Setup" that has the right command line to use?
Member
Author
|
Replaced by #123067 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since removing the build setup step, copilot is being lazy about doing the baseline setup. Try to coax it to do it more aggressively.