Skip to content

Jj/mnname#2352

Merged
ribbanya merged 48 commits intodoldecomp:masterfrom
jurrejelle:jj/mnname
Mar 26, 2026
Merged

Jj/mnname#2352
ribbanya merged 48 commits intodoldecomp:masterfrom
jurrejelle:jj/mnname

Conversation

@jellejurre
Copy link
Copy Markdown
Contributor

@jellejurre jellejurre commented Mar 25, 2026

No description provided.

jellejurre and others added 30 commits March 23, 2026 21:46
Match mnName_8023749C
0e8ac2e
Match IsNameListFull (97%)
2b77c0c 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_GetColumnCount (98%)
e1462ee 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_80238A04 (98%)
e3d20bb 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match CompareNameStrings (74%)
66c6fc4 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_80238AE0 (97%)
7748f23 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_80238754 (89%)
336e0b2 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match DeleteName (93%)
1c09ce6 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_80239878 (92%)
cefe208 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_80237D94 (98%)
91c195d 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match fn_8023A0BC (92%)
2b24685 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_ConfirmNameDeleteInput (90%)
d256af2 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_8023A290 (93%)
a4c2f72 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_MainInput (90%)
5016854 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match fn_80239574 (94%)
7428079 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_8023A9B4 (91%)
f97aff1 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_8023A59C (91%)
c0c0773 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_SortNames (87%)
00fab47 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_80239A24 (87%)
b56efe4 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_80238C34 (91%)
057aab9 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnName_8023AC40 (81%)
be77186 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
remove target funcvs
74bddfd
@jurrejelle
resolve build errors
510c0b3
@jurrejelle
100% of IsNameListFull
88c7800
@jurrejelle
100% of mnName_80237D94
a9b146a
@jurrejelle
100% of mnName_GetColumnCount
adb73ef
@jurrejelle
100% of mnName_80238A04
427c70d
ugly match of CompareNameStrings, needs more permuting, fix types
fd30bd9
Get CompareNameStrings back down to 79%, but way more likely semantic…
0d72bb3 
…ally correct
Back up to 96% with inline, honestly happy to call it a day here
efcb469
@jellejurre jellejurre marked this pull request as draft March 25, 2026 13:43
@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Mar 25, 2026 •
edited
Loading

Report for GALE01 (51e6b49 - f97f153)

📈 Matched code: 60.49% (+0.10%, +3956 bytes)

✅ 11 new matches
Unit Item Bytes Before After
main/melee/mn/mnname fn_80239574 +772 0.00% 100.00%
main/melee/mn/mnname mnName_80237D94 +484 0.00% 100.00%
main/melee/mn/mnname fn_8023A0BC +468 0.00% 100.00%
main/melee/mn/mnname mnName_80239878 +428 0.00% 100.00%
main/melee/mn/mnname DeleteName +392 0.00% 100.00%
main/melee/mn/mnname mnName_80238754 +384 0.00% 100.00%
main/melee/mn/mnname mnName_80238AE0 +340 0.00% 100.00%
main/melee/mn/mnname mnName_8023749C +4 97.84% 100.00%
main/melee/mn/mnname IsNameListFull +3 97.69% 100.00%
main/melee/mn/mnname mnName_GetColumnCount +3 98.72% 100.00%
main/melee/mn/mnname mnName_80238A04 +2 99.18% 100.00%
📈 14 improvements in unmatched items
Unit Item Bytes Before After
main/melee/mn/mnname mnName_80238C34 +2114 0.00% 89.27%
main/melee/mn/mnname mnName_80239A24 +1053 0.00% 89.55%
main/melee/mn/mnname mnName_8023A59C +1040 0.00% 99.30%
main/melee/mn/mnname mnName_8023AC40 +919 0.00% 84.20%
main/melee/mn/mnname mnName_MainInput +885 0.00% 91.90%
main/melee/mn/mnname mnName_8023A290 +758 0.00% 97.24%
main/melee/mn/mnname mnName_SortNames +722 0.00% 89.02%
main/melee/mn/mnname mnName_8023A9B4 +633 0.00% 97.09%
main/melee/mn/mnname mnName_ConfirmNameDeleteInput +496 0.00% 96.24%
main/melee/mn/mnname CompareNameStrings +321 0.00% 95.71%
main/melee/mn/mnname .data +125 0.00% 9.58%
main/melee/mn/mnname .bss +120 0.00% 71.43%
main/melee/mn/mnname .sdata2 +64 0.00% 88.89%
main/melee/mn/mnname .sdata +11 37.14% 53.85%

@jellejurre jellejurre marked this pull request as ready for review March 26, 2026 11:19
@ribbanya ribbanya merged commit 70db6bd into doldecomp:master Mar 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jellejurre @ribbanya @jurrejelle