refactor: Drop C usage in ax25_pad2.go#377
Merged
doismellburning merged 1 commit intomainfrom Feb 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the ax25_pad2.go file to eliminate C interop (cgo) dependencies, replacing C pointer arithmetic and memory operations with native Go equivalents. This improves code maintainability, removes the dependency on the unsafe package, and actually fixes a memory leak that existed in the original code.
Changes:
- Removed C imports (
import "C"andunsafepackage) and addedbytespackage - Replaced C pointer arithmetic with direct Go array indexing
- Replaced C memory operations (
C.memcpy,C.memset,C.CBytes) with native Go functions (copy,bytes.Repeat) - Removed unnecessary null terminators that were only needed for C string compatibility
- Changed type signatures from
C.inttointfor consistency with Go conventions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
doismellburning
force-pushed
the
feature/go-ax25_pad2
branch
from
8444e6a to
5115e6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.