Extend underscore naming strategy for camelCase properties with uppercase sequences#12359
Open
sherifss wants to merge 1 commit intodoctrine:3.6.xfrom
Open
Conversation
…two uppercase sequences Property names like allowedXAmount were previously converted to allowed_xamount, which is inconsistent with expected snake_case conversion.
Member
|
I'm afraid this is a breaking change. Looking at the history, we take changes to column name seriously: #7908 |
Author
|
@greg0ire Thank you very much for the context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current underscore naming strategy incorrectly converts camelCase property names that contain two consecutive uppercase letters. Examples below:
Before:
After:
Previously, this required explicitly specifying the column name in the mapping. This change adjusts the regex to handle uppercase sequences while preserving existing behavior for other cases.