[wip] Allow the device vector to shrink.#11933
Draft
trivialfis wants to merge 4 commits intodmlc:masterfrom
Draft
[wip] Allow the device vector to shrink.#11933trivialfis wants to merge 4 commits intodmlc:masterfrom
trivialfis wants to merge 4 commits intodmlc:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the device vector to shrink its allocated memory when resized to significantly smaller sizes, reducing memory consumption. The implementation uses a "dynamic table" approach where the vector only deallocates and shrinks when the new size falls below half the current capacity.
Changes:
- Modified
resize()to conditionally shrink capacity when new size is less than half of current capacity - Updated
clear()to immediately deallocate memory and reset capacity to 0 - Added comprehensive tests for both shrinking scenarios (first and second half of dynamic table)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/common/device_vector.cuh | Implements shrinking logic in resize() and immediate deallocation in clear() |
| tests/cpp/common/test_device_vector.cu | Adds test coverage for shrinking behavior in both halves of the dynamic table and verifies clear() deallocates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need benchmarks for training and prediction.