support SkipDatabaseRollback also on parent classes#342
Merged
Conversation
dmaicher
force-pushed
the
attr_inheritance
branch
from
fffb501 to
df987b7
Compare
|
Whats the easiest way to test without manually dropping files in? my composer.josn includes dev requirement The few quick composer attempts i made didnt work |
|
Figured out how to test the PR this change seems to fix my issue |
|
8.6.0 fixed the issue and now the attribute works great in my case, thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did some benchmarks on PHP 8.4 with 100.000 tests and the performance overhead is negligible so let's also support parent classes for the
SkipDatabaseRollbackattribute.