Skip to content

Noxdk/device registry#34

Open
lunds wants to merge 2 commits intodkjonas:masterfrom
lunds:noxdk/device_registry
Open

Noxdk/device registry#34
lunds wants to merge 2 commits intodkjonas:masterfrom
lunds:noxdk/device_registry

Conversation

@lunds
Copy link
Copy Markdown

@lunds lunds commented May 15, 2022

@noxdk made a great addition to make the device show up as a fully-fledged device in HA.
This makes it so much easier to find in the config pages. I merely fixed a merge-conflict on unique-id.

I suggest we join forces here in @dkjonas's original repo, hence this PR :-)

@jascdk
Copy link
Copy Markdown

jascdk commented Oct 1, 2022

@noxdk Hi:) Great additions you have made to the AHC integration:) If you use Home Assistant - I can strongly recommend this repo also https://github.com/heinekmadsen/esphome_components - it implements the AHC controller into esphome :) If you have the time - I have thought about making some additions to the ESPHOME code to utilize the "lock mode" as a switch - but I have some trouble figuring out how the modbus works on this unit. The author of the ESPHOME integration does not have so much time right now digging into it - can you help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants