Noxdk/device registry#34
Open
lunds wants to merge 2 commits intodkjonas:masterfrom
Open
Conversation
|
@noxdk Hi:) Great additions you have made to the AHC integration:) If you use Home Assistant - I can strongly recommend this repo also https://github.com/heinekmadsen/esphome_components - it implements the AHC controller into esphome :) If you have the time - I have thought about making some additions to the ESPHOME code to utilize the "lock mode" as a switch - but I have some trouble figuring out how the modbus works on this unit. The author of the ESPHOME integration does not have so much time right now digging into it - can you help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@noxdk made a great addition to make the device show up as a fully-fledged device in HA.
This makes it so much easier to find in the config pages. I merely fixed a merge-conflict on unique-id.
I suggest we join forces here in @dkjonas's original repo, hence this PR :-)