Open
Conversation
Once this version has been uploaded, future versions can be uploaded via OTA by uncommenting upload_protocol and upload_port in platformio.ini.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if the project is stable in terms of Wavin support, I think we may need to adapt to Home-assistant changes in future, so OTA will definitely be nice to have.
@paller made a nice OTA support in his fork, which fixes #12.
I suggest we join forces here in @dkjonas's original repo, hence this PR mainly with paller's code :-)
My minor contribution was to add upload port definitions to platformio.ini.
I kept the definitions commented, to not interfere with first-time uploads via USB.