This repository was archived by the owner on Jan 11, 2019. It is now read-only.
Open
Conversation
…pparently senseless piece of code.
styles to make them more appropriate for CMS use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note this is my first contribution to any public Django codebase, so you may have suggestions for further changes before accepting this request. It's some time since I used Django and I was never heavily into it. I am not necessarily aware of current best practices as I have only jsut started working with django-cms.
Basically I have added another model column, style, set by drop-down in the editing widget. This is used to set the class of the generated table and select one of a number of styles specified in an auxiliary CSS file.
I have tested the schema migration, which appears to work (I haven't used South before, either).