Open
Conversation
hannojg
requested changes
Jul 15, 2025
There was a problem hiding this comment.
This gives build errors for me, where its trying to use gold for linking which is not supported on macOS (so i suspect it might fail for other people / CI as well)
I think you had some other changes where you added it to the CMakeLists, so this is ideally what we want.
I just want to point out that Meta is saying here, that they already enable LTO for all react native targets:
however, if we really see gains with that (do you have numbers on that), then i think something might be broken with their setup
Author
|
it was added later facebook@f107c28 not in 78 |
hannojg
force-pushed
the
0.78.0-discord
branch
from
6c9c858 to
9785447
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
Test Plan: