Defer creating component provider list until we have to and optimistically create it on a separate thread#79
Open
Szymon20000 wants to merge 6 commits into0.78.0-discordfrom
Open
Defer creating component provider list until we have to and optimistically create it on a separate thread#79Szymon20000 wants to merge 6 commits into0.78.0-discordfrom
Szymon20000 wants to merge 6 commits into0.78.0-discordfrom
Conversation
hannojg
approved these changes
Jul 15, 2025
hannojg
left a comment
hannojg
left a comment
There was a problem hiding this comment.
LGTM, just some minor NITs (don't have to be addressed if you don't feel like it)
Comment on lines
+30
to
+31
| void ComponentDescriptorRegistry::addMultipleAsync( | ||
| std::vector<ComponentDescriptorProvider> providers) const { |
There was a problem hiding this comment.
NIT: do we want to make this a rvalue reference && to make obvious that the function wants to take ownvership?
| #include <react/renderer/core/ComponentDescriptor.h> | ||
| #include <react/renderer/core/InstanceHandle.h> | ||
| #include <react/utils/ContextContainer.h> | ||
| #include <thread> |
There was a problem hiding this comment.
NIT: as we only need that in the implementaton lets move it to the cpp file to keep the header clean?
hannojg
force-pushed
the
0.78.0-discord
branch
from
6c9c858 to
9785447
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
Test Plan: