Claude fix for stroke positioning in iOS.#132
Draft
andrewkunkel wants to merge 2 commits into0.81.4-discordfrom
Draft
Claude fix for stroke positioning in iOS.#132andrewkunkel wants to merge 2 commits into0.81.4-discordfrom
andrewkunkel wants to merge 2 commits into0.81.4-discordfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This code is used for rendering display name styles on iOS, whereas Android is rendered with
StrokeStyleSpan(see last PR). Android is currently working correctly, where the stroke does not affect the space occupied by the text in the UI, whereas on iOS there's a visible shift when a stroke is introduced. With this fix, the text height is no longer impacted by the stroke, which is most visible when editing display name styles.Changelog:
Test Plan:
Followed the instructions for testing React Native changes locally, and confirmed that the fix is present and working as intended for display name styles.