-
-
Notifications
You must be signed in to change notification settings - Fork 46
Offline First Implementation for Learn Progress and Jobs List Page #3606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
360c885
29bcae1
00cf4c6
4b36d86
a07dab9
7da4b93
3ce3681
af51927
5ef5306
64fda8a
94eade6
e7b2633
c1b6665
08fdff9
70b1643
121fa45
ea88482
3fb215a
0c3a8d8
a5e42ea
cf7fca0
e1d17b2
c61b707
4d96793
3c4468a
feadf3c
9de3658
a9bedad
a3dbffe
9932950
7dd5c51
cd1a128
751a99d
cb8b403
71c857f
8133100
d5f5c13
d36c5db
faba487
1dbcac0
413adb6
81f24d4
f2e610a
55dc6af
42a5663
4ed2dbe
558a17e
df28dc3
c38396d
862b90e
aa2c97c
4fb5cf3
ddcb4fb
6619993
95793ea
e9cd81d
cff2d2c
153decb
e2097c3
e6371c8
4574bd4
090c7c5
2b3000c
f3f212e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We already have a class for this:
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Think that is not a straightfroward change and will increase the PR scope quite a lot as it would mean changing a lot of network methods and exposing all APIs via
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree that this will be a significant scope change and I'm cool with leaving it as-is for now. But, how do you feel about creating a new backlog ticket to do this refactor? On first impression, it seems that we have two classes serving the same purpose at a high-level because they are both API services within Connect. Maybe we should also add a short code comment at the top of |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package org.commcare.connect.network | ||
|
|
||
| import okhttp3.ResponseBody | ||
| import retrofit2.Response | ||
| import retrofit2.http.GET | ||
| import retrofit2.http.Header | ||
| import retrofit2.http.HeaderMap | ||
| import retrofit2.http.Path | ||
|
|
||
| interface ConnectApiService { | ||
| @GET(ApiEndPoints.connectOpportunitiesURL) | ||
| suspend fun getConnectOpportunities( | ||
| @Header("Authorization") authorization: String, | ||
| @HeaderMap headers: Map<String, String>, | ||
| ): Response<ResponseBody> | ||
|
|
||
| @GET(ApiEndPoints.connectLearnProgressURL) | ||
| suspend fun getLearningProgress( | ||
| @Header("Authorization") authorization: String, | ||
| @Path("id") jobId: String, | ||
| @HeaderMap headers: Map<String, String>, | ||
| ): Response<ResponseBody> | ||
| } |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.