Skip to content

Fix test manifest options and handle @json type gracefully#260

Merged
mielvds merged 3 commits into
masterfrom
fix-flatten-test
May 11, 2026
Merged

Fix test manifest options and handle @json type gracefully#260
mielvds merged 3 commits into
masterfrom
fix-flatten-test

Conversation

@mielvds
Copy link
Copy Markdown
Collaborator

@mielvds mielvds commented May 7, 2026

This PR fixes the last outstanding tests for flatten() and frame().
In includes two fixes:

  • Options from the test manifest now override the options configured in create_test_options(), instead of the other way around. In case of extractAllScripts, the default is True, while most tests except one expect False. However, in the test manifest False is the default and therefore not explicitly provided. Hence, there was no way to provide this value through the test setup.
  • When @type is @json in a frame, it no longer raises an "Invalid JSON-LD syntax" error.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

@mielvds mielvds force-pushed the fix-compact-tc028 branch from 2f4f18a to dfa8d4b Compare May 11, 2026 09:36
Base automatically changed from fix-compact-tc028 to master May 11, 2026 09:53
@mielvds mielvds force-pushed the fix-flatten-test branch from a0f2cc1 to 1a60a36 Compare May 11, 2026 10:02
@mielvds mielvds merged commit 83acdd8 into master May 11, 2026
16 checks passed
@mielvds mielvds deleted the fix-flatten-test branch May 11, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants