-
Notifications
You must be signed in to change notification settings - Fork 247
compiler: Enhance IR to support more advanced parlang (CUDA/HIP/SYCL) features #2822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2822 +/- ##
=======================================
Coverage 83.02% 83.02%
=======================================
Files 248 248
Lines 51075 51168 +93
Branches 4492 4499 +7
=======================================
+ Hits 42403 42484 +81
- Misses 7901 7910 +9
- Partials 771 774 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6a6feb1 to
d1d4020
Compare
| def __hash__(self): | ||
| return hash((super().__hash__(), self.sub_iterators, | ||
| self.directions)) | ||
| return hash((super().__hash__(), self.sub_iterators, self.directions)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth having a _hashable_content attached to Space with a
def __hash__(self):
return hash((type(self).__name__,) + tuple(getattr(i) for i in self._hashable_content))and extending _hashable_content with each subclass?
I think it might improve concision, maintainability, and readability
99% of this has already been reviewed in #2748, but I prefer to open a new one so that the branch names across OSS and PRO match up , since the PRO PR is huge
This one has also been rebased on latest
main