Skip to content

Conversation

@FabioLuporini
Copy link
Contributor

99% of this has already been reviewed in #2748, but I prefer to open a new one so that the branch names across OSS and PRO match up , since the PRO PR is huge

This one has also been rebased on latest main

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 88.82353% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.02%. Comparing base (6061b76) to head (d1d4020).

Files with missing lines Patch % Lines
devito/passes/iet/definitions.py 72.72% 6 Missing and 3 partials ⚠️
devito/ir/support/guards.py 0.00% 2 Missing and 2 partials ⚠️
devito/passes/iet/engine.py 75.00% 4 Missing ⚠️
devito/arch/archinfo.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2822   +/-   ##
=======================================
  Coverage   83.02%   83.02%           
=======================================
  Files         248      248           
  Lines       51075    51168   +93     
  Branches     4492     4499    +7     
=======================================
+ Hits        42403    42484   +81     
- Misses       7901     7910    +9     
- Partials      771      774    +3     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.41% <62.12%> (-0.03%) ⬇️
pytest-gpu-nvc-nvidiaX 68.95% <62.12%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

def __hash__(self):
return hash((super().__hash__(), self.sub_iterators,
self.directions))
return hash((super().__hash__(), self.sub_iterators, self.directions))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth having a _hashable_content attached to Space with a

def __hash__(self):
    return hash((type(self).__name__,) + tuple(getattr(i) for i in self._hashable_content))

and extending _hashable_content with each subclass?

I think it might improve concision, maintainability, and readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants