fix(yaml): exclude managedBy from ResourceGroupSnapshot#29
Merged
Conversation
Mirrors the existing pattern used for MonitorSnapshot — `managedBy` is a mutation signal (provenance), not declarative state, and should not participate in snapshot diffs. Pre-emptive: required when the API exposes `managedBy` on UpdateResourceGroupRequest (devhelmhq/mono#362). Without this, the CLI's regen-from-spec build fails with TS2322 because toDesiredSnapshot/toCurrentSnapshot don't (and shouldn't) populate the new field. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the existing pattern used for
MonitorSnapshot—managedByis a mutation signal (provenance), not declarative state, and should not participate in snapshot diffs.Why now
Pre-emptive change for devhelmhq/mono#362, which adds
managedByto AlertChannel/StatusPage/ResourceGroup DTOs (and their Create/Update request bodies).When that PR's spec is regenerated by the CLI (
scripts/regen-from.sh), the newmanagedByproperty appears onSchemas['UpdateResourceGroupRequest'], which makesRequired<Schemas['UpdateResourceGroupRequest']>requiremanagedBy: ...everywhere — including intoDesiredSnapshot/toCurrentSnapshot, which (correctly) don't populate it.Result: the mono PR's Evolution Harness fails the CLI surface with TS2322:
This change exempts
managedByfrom theRequired<>projection so the snapshot type stays declarative-state-only, exactly like the Monitor handler does at line 693.Test plan
npm run typecheck— passesnpm run build— passes (manifest still generates correctly)Made with Cursor