Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables testing with astropy 7.x on GitHub Actions and replaces the deprecated numpy.in1d function with numpy.isin to ensure compatibility with future numpy versions.
Key Changes:
- Updated astropy version constraints from
<7to<8for Python 3.13 and 3.12 test matrices - Replaced all occurrences of deprecated
numpy.in1dwithnumpy.isin(2 instances)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/python-package.yml |
Updated astropy version constraint to <8 for Python 3.13 and 3.12 test configurations to enable astropy 7.x testing |
py/desisurvey/plots.py |
Replaced deprecated np.in1d with np.isin for checking weather weights membership |
py/desisurvey/old/progress.py |
Replaced deprecated np.in1d with np.isin for filtering passes in the completed method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sbailey
added a commit
that referenced
this pull request
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the GitHub actions test matrix to include astropy/7.x . Tests pass with astropy 7.1.0 at NERSC so I'm optimistic that they will also pass on GitHub. It also replaces deprecated
numpy.in1dwithnumpy.isin.