Add (optional) peak metrics from skycorr-PCA to the sky*.fits files#2707
Draft
Add (optional) peak metrics from skycorr-PCA to the sky*.fits files#2707
Conversation
Contributor
Author
|
Correction: the additional HDUs are not sufficient to compute skycorr-PCA templates. To do that, we would also need to save the peak wavelength and the DWAVE/DLSF errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the option to add the sky line peak metrics that can be useful diagnostics –– see the example below. Specifically, it adds these 6 FITS HDUs: PEAK_DW_BEFORE, PEAK_DLSF_BEFORE, PEAK_CHI2PDF_BEFORE, PEAK_DW_AFTER, PEAK_DLSF_AFTER, PEAK_CHI2PDF_AFTER.
The addition HDUs only increases the file size by ~10%, and since the sky files are already small (~5 MB), the size increase would be quite negligible. So we could also consider adding these HDUs as a default (right now it is disabled by default). The other advantage of having these HDUs is that we can use them to directly compute the skycorr-PCA templates –– the current procedure requires rerunning desi_proc which is very cumbersome.
I should note that while I have tested the new code by running desi_compute_sky, I have not done extensive testing with the full pipeline.