Open
Conversation
1 task
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
Walkthrough여정 상세의 타임라인 레이아웃을 세로에서 가로로 전환하고, 막대 차트의 너비 분배 알고리즘과 UI 치수 상수를 추가·조정했습니다. 내부 레이아웃·렌더링 로직과 일부 텍스트 측정/트렁케이션 로직이 변경되었습니다. 변경사항
예상 코드 리뷰 노력🎯 4 (Complex) | ⏱️ ~50분 기술적 주의사항:
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@app/src/main/java/com/depromeet/team6/presentation/ui/itinerary/component/ItineraryInfoDetailLegs.kt`:
- Line 18: There are duplicate imports of the same Compose Box type (one as Box
and one aliased as LayoutBox) and both Box and LayoutBox are used
interchangeably; remove the redundant aliased import (LayoutBox) and standardize
all usages to the single imported symbol (choose either Box or LayoutBox but
keep one) in this file, updating references where Box/LayoutBox are used (search
for Box and LayoutBox in ItineraryInfoDetailLegs.kt) and ensure imports only
include the chosen name.
In
`@app/src/main/java/com/depromeet/team6/presentation/ui/itinerary/component/SummaryBarChart.kt`:
- Around line 165-177: The code in SummaryBarChart.kt can produce negative
allocated widths if LegInfo.sectionTime is negative; update the computation to
treat sectionTime as non-negative by using leg.sectionTime.coerceAtLeast(0) when
computing remainingTimeSum and when calculating each leg's allocation (so
remainingTimeSum = legs.sumOf { it.sectionTime.coerceAtLeast(0)
}.coerceAtLeast(1) and use the same non-negative value for per-leg ratio),
keeping the existing min width and equal-distribution fallback logic intact.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 755bc2b6-44dc-4bc2-bcb8-128af146b02d
📒 Files selected for processing (5)
app/src/main/java/com/depromeet/team6/presentation/ui/itinerary/component/ItineraryInfoDetail.ktapp/src/main/java/com/depromeet/team6/presentation/ui/itinerary/component/ItineraryInfoDetailLegs.ktapp/src/main/java/com/depromeet/team6/presentation/ui/itinerary/component/ItinerarySummary.ktapp/src/main/java/com/depromeet/team6/presentation/ui/itinerary/component/SummaryBarChart.ktapp/src/main/java/com/depromeet/team6/presentation/util/Dimens.kt
...main/java/com/depromeet/team6/presentation/ui/itinerary/component/ItineraryInfoDetailLegs.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/depromeet/team6/presentation/ui/itinerary/component/SummaryBarChart.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@app/src/main/java/com/depromeet/team6/presentation/ui/itinerary/component/ItineraryInfoDetailLegs.kt`:
- Line 276: The hardcoded dot offsets (14.dp / 6.dp) used for the drop-off
marker positions should be derived from the existing timeline metrics instead of
fixed values; replace usages with calculations based on timelineAxisOffset,
timelineIconSize (and timelineTimeIconGap / timelineTimeSlotWidth if needed) so
the marker x/y aligns with the axis math (e.g., compute center =
timelineAxisOffset and halfIcon = timelineIconSize / 2 and use those to position
the marker). Update all places referencing the hardcoded 14.dp/6.dp (including
the code around the timelineAxisOffset declaration, DetailLegsSubway placement,
and the other two occurrences noted) to use the derived values so future Dimens
changes remain consistent with the axis calculation.
- Around line 800-806: The branch computing useCompactSingleLine is based only
on stationName measurement (stationLayout) which allows the suffix label ("하차")
to be truncated; change the decision to measure the combined string (e.g.,
stationName plus the suffix/space) using textMeasurer.measure with the same
stationStyle and Constraints, and derive useCompactSingleLine from that
combinedLayout.lineCount > 2 so the rendering block that uses maxLines = 2 won't
drop the suffix; apply the same change to the similar logic referenced later
(the other measurement around the same UI block) so both places use the
combined-string measurement to decide compact/expanded layout.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 55e1fb15-d94e-45ca-8779-be3279531918
📒 Files selected for processing (1)
app/src/main/java/com/depromeet/team6/presentation/ui/itinerary/component/ItineraryInfoDetailLegs.kt
...main/java/com/depromeet/team6/presentation/ui/itinerary/component/ItineraryInfoDetailLegs.kt
Show resolved
Hide resolved
...main/java/com/depromeet/team6/presentation/ui/itinerary/component/ItineraryInfoDetailLegs.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
PR 발행 전 체크 리스트
스크린샷 (선택)
💬리뷰 요구사항(선택)
그런 부분은 일단 보고 수정해두긴 했는데 원래 담당자 현석오빠 함 확인해보고 이상한 부분 있으면 얘기해주세요~~
Summary by CodeRabbit
릴리스 노트