fix(publish): Replace unwrap() calls with error handling in provenance generation#31960
Open
fix(publish): Replace unwrap() calls with error handling in provenance generation#31960
Conversation
Co-authored-by: littledivy <34997667+littledivy@users.noreply.github.com>
Co-authored-by: littledivy <34997667+littledivy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix panic issue when publishing deno package from CI container
fix(publish): Replace unwrap() calls with error handling in provenance generation
Jan 27, 2026
Member
|
@copilot please run |
Co-authored-by: bartlomieju <13602871+bartlomieju@users.noreply.github.com>
Contributor
Author
Done. Applied rustfmt formatting in commit e585c4d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed panic in
deno publishwhen running in CI containers by replacing all unwrap() calls in the provenance generation code with proper error handling. The changes ensure clear, actionable error messages are shown instead of panics.Key changes:
transparency_logs.iter().next().unwrap()withok_or_else()to provide clear error when Rekor returns no log entriesrel_ref.find('@').unwrap()withok_or_else()to show which GITHUB_WORKFLOW_REF value is invalidunwrap()calls withmap_err()to show exactly which env var is missingPredicate::new_github_actions()andProvenanceAttestation::new_github_actions()to returnResult<T, AnyError>to properly propagate errorsAll code review and security checks passed with no issues.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.