fix: broken package / import assertion #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wanted to do the same, thank you. This is imho an urgent PR to merge as a lot of people are now updating to Deno2 :) |
Contributor
Author
|
I've updated the PR to include a fix for Tests are passing. @crowlKats let me know if there's anything else I can do to help land this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is currently broken on Deno v2
Dependency emoji v0.3.0 uses a legacy import assertion
import emojis from "./all.json" assert { type: "json" };which Deno 2 now exits with an error.
This is fixed in v0.3.1 by @lino-levan with the
with { type: "json" }syntax.This PR updates the dependency pinning to pull the correct version in.
Verified & tested it now runs as expected locally.