improvement: Add Device: move buttons to menu#6126
Merged
Conversation
Member
Author
|
I'll fix tests if / when this MR is deemed acceptable functionality-wise. |
WofWca
force-pushed
the
wofwca/5a6b44ac07
branch
from
4211c0b to
c91a829
Compare
Member
|
Maybe @r10s can have a look about this UI change? I'm not sure if it is an improvement to move the "Troubleshooting" to the context menu just to gain space for "very very little" screens (< 600px height) |
nicodh
force-pushed
the
wofwca/7fecbad8c1
branch
from
595a9ce to
c4e55c5
Compare
WofWca
commented
Apr 20, 2026
WofWca
commented
Apr 20, 2026
nicodh
approved these changes
Apr 21, 2026
Again, this gives more space to the QR code itself. Co-authored-by: Nico de Haen <ndh@deltachat.de>
WofWca
force-pushed
the
wofwca/7fecbad8c1
branch
from
c4e55c5 to
83d831c
Compare
Member
Author
|
Rebased, removed @nicodh thanks for fixing the tests! So I heard that there are debates about whether this MR is good, is it settled now? Can be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This little dialog can fit so many pixels.
TODO: