[Spark] Add conflict checking for feature additions to protocol#6106
Open
itsbilal wants to merge 2 commits intodelta-io:masterfrom
Open
[Spark] Add conflict checking for feature additions to protocol#6106itsbilal wants to merge 2 commits intodelta-io:masterfrom
itsbilal wants to merge 2 commits intodelta-io:masterfrom
Conversation
Previously, we only failed on feature additions to the protocol if that feature was not understood by a losing transaction's writer. This change updates the conflict checker to fail on concurrent addition of a feature to the protocol if the presence of that feature in the protocol could have imposed requirements on that write. This increases safety with protocol additions as some features impose requirements on all writes even if the feature isn't explicitly enabled in metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Previously, we only failed on feature additions to the protocol if that feature was not understood by a losing transaction's writer. This change updates the conflict checker to fail on concurrent addition of a feature to the protocol if the presence of that feature in the protocol could have imposed requirements on that write. This increases safety with protocol additions as some features impose requirements on all writes even if the feature isn't explicitly enabled in metadata.
How was this patch tested?
Unit tests
Does this PR introduce any user-facing changes?