refactor: share checkpoint read planning across scan metadata paths#2459
Open
ethan-tyler wants to merge 6 commits intodelta-io:mainfrom
Open
refactor: share checkpoint read planning across scan metadata paths#2459ethan-tyler wants to merge 6 commits intodelta-io:mainfrom
ethan-tyler wants to merge 6 commits intodelta-io:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2459 +/- ##
==========================================
- Coverage 88.39% 88.38% -0.01%
==========================================
Files 175 175
Lines 58121 58421 +300
Branches 58121 58421 +300
==========================================
+ Hits 51375 51637 +262
- Misses 4784 4804 +20
- Partials 1962 1980 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Ethan Urbanski <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scan_metadata()andparallel_scan_metadata()had separate checkpoint planning logic. The parallel path used a conservative hard codedCheckpointReadInfoand could miss projected checkpoint capabilities (like parsed stats columns) that the normal path already understood.This fix here is to centralize projected checkpoint planning in
LogSegment, letCheckpointManifestReaderaccept a caller planned schema, and thread it through the sequential phase allowing both paths to use the same checkpoint knowledge.For single part checkpoints, the parallel path defers finalization until the sequential phase knows which files it's handing off, then updates the replay processor before parallel processing begins.
This is an internal only change
Tests cover
stats_parsedpreservation andpartition_values_parsedplanning for single part checkpoints in the parallel path.