refactor: move data file methods behind SupportsDataFiles trait#2386
Merged
scottsand-db merged 1 commit intodelta-io:mainfrom Apr 23, 2026
Conversation
This was referenced Apr 14, 2026
d53a0ff to
266aac1
Compare
scottsand-db
approved these changes
Apr 16, 2026
1c48472 to
50130c3
Compare
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
…2385) ## Stacked PR Use this [link](https://github.com/delta-io/delta-kernel-rs/pull/2385/files) to review incremental changes. - [**stack/alter-table-1-refactor-state**](#2385) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2385/files)] - [stack/alter-table-2-supports-data-files](#2386) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2386/files/029d6672081d32caea314dca61f3688e841f3036..50130c30c4378997fbf3d0ef7426ce23992e5c85)] - [stack/alter-table-3-framework-add-column](#2387) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2387/files/50130c30c4378997fbf3d0ef7426ce23992e5c85..eaa5277d025434aa78b79beed1a7cedfe82aa621)] - [stack/alter-table-4-set-nullable](#2388) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2388/files/eaa5277d025434aa78b79beed1a7cedfe82aa621..7506e1273ef349fbf628e4a6db5d0e7c1b4cbd8b)] - [stack/alter-table-5-column-mapping-add](#2389) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2389/files/7506e1273ef349fbf628e4a6db5d0e7c1b4cbd8b..d943ca2945da1ec9c354db57c889d93456381dee)] - [stack/alter-table-6-drop-column](#2390) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2390/files/d943ca2945da1ec9c354db57c889d93456381dee..40e3a1ff9e2915b456d0f0a76a50eb67f27a1ab1)] - [stack/alter-table-7-rename-column](#2391) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2391/files/40e3a1ff9e2915b456d0f0a76a50eb67f27a1ab1..628af3c02767f008a4e3c80a146aec7e5a3ac0b3)] --------- ## What changes are proposed in this pull request? Splits Transaction's snapshot into two concerns: - `read_snapshot_opt: Option<SnapshotRef>` -- the pre-commit table state (None for CREATE TABLE) - `effective_table_config: TableConfiguration` -- the config this commit will produce This separates "what did I read?" (conflict detection, post-commit snapshots) from "what will this commit produce?" (schema, protocol, stats, write context). Write-path call sites read from `effective_table_config`; read-path call sites use `read_snapshot()`. Also adds `should_emit_protocol` / `should_emit_metadata` flags to replace the old `is_create_table()` checks for Protocol/Metadata action emission, and replaces the synthetic pre-commit snapshot in CREATE TABLE with direct `TableConfiguration` construction. This is a pure refactor with no behaviour change. ## How was this change tested? All existing tests pass. Added unit tests for `LogSegment::new_for_version_zero` (valid input, non-zero version rejection, non-commit file rejection).
50130c3 to
25e133d
Compare
25e133d to
3c9a347
Compare
This was referenced Apr 22, 2026
nicklan
approved these changes
Apr 23, 2026
Introduce a SupportsDataFiles marker trait implemented by ExistingTable and CreateTable (but not the future AlterTable). Move public data file methods (add_files_schema, stats_schema, stats_columns, get_write_context, add_files) behind this trait bound. Internal generate_* methods remain on impl<S> since they handle empty data gracefully and are called from the shared commit path. This enables compile-time prevention of data file operations on metadata-only transaction types like AlterTable.
3c9a347 to
a71c8b8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2386 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 175 175
Lines 57753 57753
Branches 57753 57753
=======================================
Hits 51059 51059
Misses 4750 4750
Partials 1944 1944 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sanujbasu
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
Introduce a
SupportsDataFilesmarker trait to gate data-file methods at compile time. This prevents future metadata-only transaction types (likeAlterTable) from accessing methods that add, remove, or configure data files.Gated behind
SupportsDataFiles(onlyExistingTableandCreateTable):stats_schema()stats_columns()generate_logical_to_physical()get_write_context()add_files()Kept on
impl<S> Transaction<S>(all transaction types):commit()with_data_change()/set_data_change()data_change: falsewith_engine_info()with_commit_info()with_transaction_id()with_domain_metadata()add_files_schema()generate_adds()which handles empty state internally. Kept ungated so it remains available if it becomes dynamic in the future.validate_add_files_stats()generate_adds()generate_remove_actions()generate_dv_update_actions()generate_adds_for_dv_update()generate_dv_update_actionsbuild_crc_delta()into_committed()/into_conflicted()/into_retryable()How was this change tested?
All existing tests pass unchanged. The trait adds compile-time safety with no runtime behavior change. A
compile_faildoctest will be added in the follow-up PR that introducesAlterTableto verify that data file methods are rejected at compile time.