playbooks/redfish: Fix security issues and consolidate job tracking#1073
Open
tobiasb-dell wants to merge 2 commits intodell:collectionsfrom
Open
playbooks/redfish: Fix security issues and consolidate job tracking#1073tobiasb-dell wants to merge 2 commits intodell:collectionsfrom
tobiasb-dell wants to merge 2 commits intodell:collectionsfrom
Conversation
- Remove hardcoded credentials and use variables for baseuri, username, password
- Replace hardcoded ca_path with optional {{ ca_path | default(omit) }}
- Standardize hosts to redfish_hosts across all playbooks
- Add connection: local to eliminate repeated delegate_to: localhost
- Add register: to all tasks for error handling
- Consolidate duplicate job tracking logic into reusable templates
- Fix typos and improve consistency in task names
Consolidated firmware job tracking into redfish_firmware_jobtracking.yml
Consolidated storage volume job tracking into redfish_storage_volume_jobtracking.yml
Collaborator
|
Can one of the admins verify this patch? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## collections #1073 +/- ##
============================================
Coverage 93.54% 93.54%
============================================
Files 296 296
Lines 46333 46333
Branches 4220 4220
============================================
Hits 43340 43340
Misses 1909 1909
Partials 1084 1084 ☔ View full report in Codecov by Sentry. |
- Remove play structure from job tracking templates (hosts, gather_facts, vars) - Files meant to be included via include_tasks should only contain tasks - Add default values for optional retry/polling variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes security vulnerabilities and improves maintainability of the Redfish playbooks.
Security Fixes
Consolidation
Created reusable job tracking templates:
Updated playbooks to use include_tasks.
Consistency Improvements
Files Changed