Fix: Isolate hooks between multiple TorchFeatureExtractor instances#122
Open
y-prudent wants to merge 3 commits intofeat/torchvision_lazy_importfrom
Open
Fix: Isolate hooks between multiple TorchFeatureExtractor instances#122y-prudent wants to merge 3 commits intofeat/torchvision_lazy_importfrom
y-prudent wants to merge 3 commits intofeat/torchvision_lazy_importfrom
Conversation
y-prudent
force-pushed
the
fix/consistent_hooks
branch
from
dde7917 to
9f6c060
Compare
y-prudent
changed the base branch from
master
to
feat/torchvision_lazy_import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Multiple
TorchFeatureExtractorinstances on the same model interfere with each other. For instance, callingplot_2D_featuresafter fitting an OOD detector corrupts the detector's hooks.Solution:
self._handles(instead of sharedself.model._ood_handles)self._active flag: hooks only execute when their extractor is activeclean_hooks()method for explicit cleanupNote: I rebased on #121 to address the Black formatting issue.