fix: interpolation for a@xb metrics#112
Open
y-prudent wants to merge 2 commits intofeat/torchvision_lazy_importfrom
Open
fix: interpolation for a@xb metrics#112y-prudent wants to merge 2 commits intofeat/torchvision_lazy_importfrom
y-prudent wants to merge 2 commits intofeat/torchvision_lazy_importfrom
Conversation
cofri
approved these changes
Jul 28, 2025
y-prudent
force-pushed
the
fix/metrics
branch
from
066f0a6 to
950b666
Compare
y-prudent
changed the base branch from
master
to
feat/torchvision_lazy_import
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
cofri
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
<aaa><XX><bbb>metrics (e.g.,fpr95tpr) used discrete lookup, returning the value at the nearest sampled threshold rather than the exact requested threshold.Solution
Replace discrete index-based lookup with
scipy.interpolate.interp1dfor accurate continuous estimation at the exact threshold value.Changes
Note: I rebased on #121 to address the Black formatting issue.