Open
Conversation
Member
|
@nitro-neal is the intention to have this vector test an intermediate representation of a VC before it gets serialized as a JWT? |
decentralgabe
approved these changes
Apr 3, 2024
Member
decentralgabe
left a comment
There was a problem hiding this comment.
this is an improvement so I will approve.
I think we should add additional vectors to verify that going from input -> VC -> VC JWT -> VC is a consistent process
Contributor
Author
|
As discussed: Every other test vector like corresponds to a function call: eg: every other one works in that you put the input and its like ‘known expected output’ Will create a new test vector |
This was referenced Apr 4, 2024
Member
|
@nitro-neal can this be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the way create works:
The input are the fields for the actual input fields of a vc with the
VerifiableCredential.create()method.The output is the comparison of the VcDataModel object to what is expected.
Note classes implementing this have can't JUST do an object to object comparison because certain things like id and issuance date will be different than the output (by design)
Example VerifiableCredential.create() vector: