Fix compilation errors in SponsorBlock and VolumeBar#373
Open
cwsteini wants to merge 4 commits intodayanch96:mainfrom
Open
Fix compilation errors in SponsorBlock and VolumeBar#373cwsteini wants to merge 4 commits intodayanch96:mainfrom
cwsteini wants to merge 4 commits intodayanch96:mainfrom
Conversation
cwsteini
commented
Oct 1, 2025
cwsteini
commented
Fix SponsorBlock compilation errors: correct method calls and remove redundant property declaration
…on with runtime function Replace problematic static BOOL volumeBar initialization with shouldShowVolumeBar() function to avoid compile-time initialization of runtime values
…laration and fix static variable initialization Fix compilation errors in SelectableLyrics.xm: ## Issues Fixed: - **Duplicate property declaration**: Removed redundant `%property (retain, nonatomic) UITextView *lyrics;` from Logos hook since property is already declared in @interface - **Static variable initialization**: Replaced `static BOOL selectableLyrics = YTMU(...)` with `shouldShowSelectableLyrics()` function to avoid compile-time initialization of runtime values ## Changes: - Removed duplicate property declaration from %hook - Changed static variable to runtime function - Updated all references from `selectableLyrics` to `shouldShowSelectableLyrics()` This resolves the compilation error that was preventing the build from completing.
…ation Remove redundant %property declaration from VolumeBar.xm that was causing Logos preprocessor to generate variable-length array code with non-const variables. The property is already declared in the @interface, so the %property declaration was unnecessary and causing compilation errors with VLA extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.