Add on_record to support tracing::field::Empty and span.record#89
Merged
oli-obk merged 2 commits intodavidbarsky:mainfrom Sep 23, 2025
Merged
Add on_record to support tracing::field::Empty and span.record#89oli-obk merged 2 commits intodavidbarsky:mainfrom
on_record to support tracing::field::Empty and span.record#89oli-obk merged 2 commits intodavidbarsky:mainfrom
Conversation
Contributor
Author
|
If you review commit by commit, you can see the effect of |
Contributor
Author
|
Clippy errors of the main branch are fixed at #90 |
21df80c to
04a547c
Compare
Collaborator
|
Good catch, thank you! and thanks for the CI fixes in separate PRs |
Collaborator
|
published as 0.4.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when
tracing::field::Emptyis used withspan.record()calls, the recorded values are lost and not displayed in span traces. This PR introduceson_recordfunctionality to preserve and display recorded values.Before
After