Skip to content

feat: add strict SSL verify-ca/verify-full support for postgres#874

Merged
vikaxsh merged 29 commits intostagingfrom
feat/postgres_ssl_ca
Mar 23, 2026
Merged

feat: add strict SSL verify-ca/verify-full support for postgres#874
vikaxsh merged 29 commits intostagingfrom
feat/postgres_ssl_ca

Conversation

@vishalm0509
Copy link
Collaborator

@vishalm0509 vishalm0509 commented Mar 18, 2026

Description

This PR adds Postgres SSL verify-ca and verify-full support with PEM certificate inputs.


⚠️ Note ⚠️
Add in release notes that the support for sslrootcert, sslcert, sslkey is removed

	if c.SSLConfiguration.ServerCA != "" {
		query.Add("sslrootcert", c.SSLConfiguration.ServerCA)
	}

	if c.SSLConfiguration.ClientCert != "" {
		query.Add("sslcert", c.SSLConfiguration.ClientCert)
	}

	if c.SSLConfiguration.ClientKey != "" {
		query.Add("sslkey", c.SSLConfiguration.ClientKey)
	}

Instead we pass the actual pem content in these fields


Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Scenario A
  • Scenario B

Screenshots or Recordings

Screenshot 2026-03-18 at 19 49 41

Documentation

  • Documentation Link: [link to README, olake.io/docs, or olake-docs]
  • N/A (bug fix, refactor, or test changes only)

Related PR's (If Any):

@vishalm0509 vishalm0509 changed the base branch from master to staging March 18, 2026 14:20
@vishalm0509 vishalm0509 temporarily deployed to integration_tests March 20, 2026 10:31 — with GitHub Actions Inactive
@vishalm0509 vishalm0509 temporarily deployed to integration_tests March 22, 2026 10:08 — with GitHub Actions Inactive
Copy link
Collaborator

@vikaxsh vikaxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a todo in Kafka for using same BuildTLSConfig function

@vishalm0509 vishalm0509 temporarily deployed to integration_tests March 23, 2026 10:05 — with GitHub Actions Inactive
@vishalm0509 vishalm0509 temporarily deployed to integration_tests March 23, 2026 10:50 — with GitHub Actions Inactive
@vikaxsh vikaxsh requested a deployment to integration_tests March 23, 2026 12:55 — with GitHub Actions Waiting
@vishalm0509 vishalm0509 temporarily deployed to integration_tests March 23, 2026 14:15 — with GitHub Actions Inactive
Copy link
Collaborator

@vikaxsh vikaxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vikaxsh vikaxsh merged commit a3b1b67 into staging Mar 23, 2026
12 of 13 checks passed
@vikaxsh vikaxsh deleted the feat/postgres_ssl_ca branch March 23, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants