update datafusion to 52 & update deps#525
Conversation
6aea70e to
6aa65b6
Compare
|
Since datafusion removed the |
|
Updates: |
1c64cf8 to
f85f7c6
Compare
272fade to
7175cef
Compare
|
@hozan23 |
The FFI_TableProvider stores a Weak reference to the TaskContextProvider, but the Arc was created locally and dropped immediately. Use a static OnceLock to keep it alive. Also update the __datafusion_table_provider__ signature for the v52 protocol and bump datafusion dependency to >=52.0.0.
|
@nuno-faria @phillipleblanc Can you have a final review please before merging to main? |
nuno-faria
left a comment
There was a problem hiding this comment.
Thanks @hozan23, overall LGTM but there appears to be an error when executing the integration tests, namely at test_flight_sql_data_source. The df.count() triggers a panic in arrow:
thread 'flight::test_flight_sql_data_source' panicked at .../arrow-select-57.3.0/src/coalesce.rs:462:9:
assertion `left == right` failed
left: 2
right: 0
According to this comment, it appears that it was not supposed to work before in the first place. As a workaround, we can convert the df.count() into a df.collect().await?.iter().map(|b| b.num_rows()).sum::<usize>().
5e100a5 to
97bdf79
Compare
|
Hi @nuno-faria Let me know if it looks good to you so we can merge it. |
nuno-faria
left a comment
There was a problem hiding this comment.
LGTM, thanks again @hozan23.
No description provided.