Skip to content

Add documentation of custom instructions for Custom DC MCP#700

Open
kmoscoe wants to merge 73 commits intodatacommonsorg:masterfrom
kmoscoe:custom_dc
Open

Add documentation of custom instructions for Custom DC MCP#700
kmoscoe wants to merge 73 commits intodatacommonsorg:masterfrom
kmoscoe:custom_dc

Conversation

@kmoscoe
Copy link
Copy Markdown
Contributor

@kmoscoe kmoscoe commented Apr 14, 2026

This PR adds instructions for using custom instructions for MCP tools in 3 different scenarios:

  • files and server are local
  • files and server are in GCP
  • files are in GCP and server is local

It also does the following:

  • a substantial refactor of the "deploy to GCP" page to make clearer how to sync to new images without necessarily building a custom image.
  • removes some unnecessary instructions
  • reorders some pages in the navigation
  • renames some files

Staged at http://bullie.svl.corp.google.com:4000/

kmoscoe and others added 30 commits June 11, 2025 19:07
@kmoscoe kmoscoe requested a review from keyurva April 14, 2026 21:45
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Custom Data Commons documentation, primarily focusing on the integration and configuration of the Model Context Protocol (MCP) server. It introduces a new configuration guide, replaces the previous MCP tools documentation, and refines deployment and image management instructions. The review feedback suggests several improvements for consistency and clarity, including the use of standard placeholders in examples, correcting directory name typos, and removing redundant configuration elements like unnecessary volume mounts and protocol prefixes.

Comment thread custom_dc/advanced.md Outdated
Comment thread custom_dc/mcp.md Outdated
Comment thread custom_dc/mcp.md Outdated
Comment thread custom_dc/deploy_cloud.md Outdated
kmoscoe and others added 9 commits April 14, 2026 14:54
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@keyurva keyurva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread custom_dc/deploy_cloud.md
Comment thread custom_dc/mcp.md Outdated
1. Edit the file(s) as necessary.
1. In your `env.list` file, set the `DC_INSTRUCTIONS_DIR` variable to your top-level instructions directory, using an absolute path. For example for a directory called `instructions` in the `website` directory:
```
DC_INSTRUCTIONS_DIR=/usr/local/google/home/username/website/instructions
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be any directory? Any reason to specify it as a directory in the website repo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe you can use it on any directory. I'll test it and make that clearer here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fixed, PTAL.

Comment thread custom_dc/deploy_cloud.md

### Start/restart the services container {#start-service}
{: #instructions}
## Optional: Provide custom MCP instructions files
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would adding a comparison table help compare the 3 scenarios - local only, gcp only, hybrid?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this is specifically about running everything in GCP.

@kmoscoe kmoscoe requested a review from keyurva April 21, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants