-
Notifications
You must be signed in to change notification settings - Fork 130
Scope gemini runs by dataset and enforce output_path format #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope gemini runs by dataset and enforce output_path format #1843
Conversation
Scope logs to per-run directory
Add coverage for run id prefix
Summary of ChangesHello @rohitkumarbhagat, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the organization and robustness of the Gemini import process. By introducing run-specific directories for all generated artifacts and enforcing a structured format for output paths, it aims to simplify debugging, improve traceability of runs, and prevent common configuration errors. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively scopes Gemini runs by dataset and enforces a stricter format for output_path. The changes are well-structured, and the updates to documentation and prompts are consistent with the new functionality. The addition of tests for the new validation logic is also a great improvement.
I've found one potential bug that could lead to a TypeError and have suggested a fix. I've also recommended an additional test case to cover this scenario. Overall, this is a solid contribution that improves the robustness and organization of the agentic import tool.
Add test for None output_path
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively scopes Gemini run artifacts by dataset, prefixing run folders with the dataset's output basename. The changes are consistently applied across the codebase, including updates to prompts, documentation, and shell scripts to reference the new run-scoped paths. A key improvement is the enforcement of a <dir>/<prefix> format for output_path, which is backed by solid validation and new unit tests.
My review includes one suggestion to combine validation checks for the output_path to improve code conciseness. Overall, this is a well-executed change that enhances the organization and traceability of run artifacts.
under .datacommons/runs/<gemini_run_id>/.
invalid output paths.