Skip to content

Conversation

@rohitkumarbhagat
Copy link
Contributor

  • Prefix gemini run folders with dataset output basename and scope run artifacts (logs/counters)
    under .datacommons/runs/<gemini_run_id>/.
  • Update prompts/docs to reference run-scoped logs and backups.
  • Require output_path to be non‑empty and in / format, with tests covering run id pathing and
    invalid output paths.

Scope logs to per-run directory
Add coverage for run id prefix
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rohitkumarbhagat, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the organization and robustness of the Gemini import process. By introducing run-specific directories for all generated artifacts and enforcing a structured format for output paths, it aims to simplify debugging, improve traceability of runs, and prevent common configuration errors.

Highlights

  • Artifact Organization: Gemini run artifacts (logs, counters) are now organized into run-specific directories under .datacommons/runs/<gemini_run_id>/, prefixed by the dataset output basename.
  • Output Path Validation: The output_path configuration now enforces a non-empty value and a / format, improving path validation and preventing common configuration errors.
  • Documentation and Prompts Update: Documentation and internal prompts have been updated to reflect the new structured logging and backup locations, guiding users to the correct places for debugging.
  • New Unit Tests: New unit tests have been added to cover the run ID pathing and the validation of output_path formats, ensuring the robustness of the changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively scopes Gemini runs by dataset and enforces a stricter format for output_path. The changes are well-structured, and the updates to documentation and prompts are consistent with the new functionality. The addition of tests for the new validation logic is also a great improvement.

I've found one potential bug that could lead to a TypeError and have suggested a fix. I've also recommended an additional test case to cover this scenario. Overall, this is a solid contribution that improves the robustness and organization of the agentic import tool.

Add test for None output_path
@rohitkumarbhagat
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively scopes Gemini run artifacts by dataset, prefixing run folders with the dataset's output basename. The changes are consistently applied across the codebase, including updates to prompts, documentation, and shell scripts to reference the new run-scoped paths. A key improvement is the enforcement of a <dir>/<prefix> format for output_path, which is backed by solid validation and new unit tests.

My review includes one suggestion to combine validation checks for the output_path to improve code conciseness. Overall, this is a well-executed change that enhances the organization and traceability of run artifacts.

@rohitkumarbhagat rohitkumarbhagat enabled auto-merge (squash) January 20, 2026 08:57
@rohitkumarbhagat rohitkumarbhagat merged commit d36dbf2 into datacommonsorg:master Jan 20, 2026
9 checks passed
@rohitkumarbhagat rohitkumarbhagat deleted the gemini-run-folder-dataset-prefix branch January 20, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants