Merged
Conversation
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
d4ca830 to
4fec00e
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
4fec00e to
9e22cc1
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
20c8c9f to
d2ab1e6
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
983d8c2 to
f209bbf
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
34a780c to
88e35dc
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
34d8931 to
4f0530b
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
645704c to
402c16b
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
22e2e16 to
b907903
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
b907903 to
cf587a2
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
3657f83 to
caab8f5
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
caab8f5 to
26eca38
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
26eca38 to
b02cf3f
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
96a7fa2 to
aecd339
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
fb03ce7 to
e50da9b
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
d0c3415 to
178cb6f
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
9365969 to
271b943
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
271b943 to
43ea67e
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
43ea67e to
8aa51f9
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
8aa51f9 to
df8edc8
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
df8edc8 to
ddadf58
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
cf53f06 to
b35a77d
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
b35a77d to
0624298
Compare
updates: - [github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0) - [github.com/psf/black-pre-commit-mirror: 25.1.0 → 25.12.0](psf/black-pre-commit-mirror@25.1.0...25.12.0) - [github.com/astral-sh/ruff-pre-commit: v0.11.2 → v0.14.10](astral-sh/ruff-pre-commit@v0.11.2...v0.14.10) - [github.com/PyCQA/isort: 6.0.1 → 7.0.0](PyCQA/isort@6.0.1...7.0.0) - [github.com/asottile/pyupgrade: v3.19.1 → v3.21.2](asottile/pyupgrade@v3.19.1...v3.21.2) - [github.com/adamchainz/blacken-docs: 1.19.1 → 1.20.0](adamchainz/blacken-docs@1.19.1...1.20.0) - [github.com/pre-commit/mirrors-mypy: v1.15.0 → v1.19.1](pre-commit/mirrors-mypy@v1.15.0...v1.19.1)
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
0624298 to
d067fc8
Compare
ikrommyd
reviewed
Jan 6, 2026
src/dask_awkward/lib/io/io.py
Outdated
| raise ValueError("divisions must be a tuple of length len(source) + 1") | ||
| hlg = HighLevelGraph.from_collections(name, dsk, dependencies=parts) | ||
| hlg = HighLevelGraph.from_collections( | ||
| name, dsk, dependencies=cast("Sequence[DaskCollection]", parts) |
Collaborator
There was a problem hiding this comment.
@martindurant I'm not an expert at python typing. I used cast here as from_collections expects a sequence of DaskCollection but I could have just instructed mypy to ignore this line. What do you think? mypy complains with error: Argument "dependencies" to "from_collections" of "HighLevelGraph" has incompatible type "list[Delayed]"; expected "Sequence[DaskCollection]" [arg-type]
Collaborator
There was a problem hiding this comment.
Even though Delayed is indeed a collection and list is indeed a sequence.
For me, when you start having to cast() here and there, you may as well be ignoring... That might be because I don't know how to do it well either!
Collaborator
There was a problem hiding this comment.
yeah since dask wants a DaskCollection type, I would have expected that all dask collections like array etc inherit from this protocol, but they don't......anyways, let me switch to ignore.
ikrommyd
reviewed
Jan 6, 2026
src/dask_awkward/lib/io/io.py
Outdated
| layer = AwkwardBlockwiseLayer.from_blockwise(layer) | ||
| hlg = HighLevelGraph.from_collections(name, layer, dependencies=[array]) | ||
| hlg = HighLevelGraph.from_collections( | ||
| name, layer, dependencies=cast("Sequence[DaskCollection]", [array]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: