[vm, simarm64] Extract CalleeRegisterVerifier class#63012
[vm, simarm64] Extract CalleeRegisterVerifier class#63012eseidel wants to merge 1 commit intodart-lang:mainfrom
Conversation
Extract the callee-saved register save/verify/restore logic from Simulator::Call into a RAII CalleeRegisterVerifier class. This reduces the inline code from ~25 lines to 3 lines and makes the pattern reusable. Change-Id: I0000000000000000000000000000000000000000
|
This is a small clean up that we did in our fork of Dart that I figured I should upstream. |
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/491682 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
https://dart-review.googlesource.com/c/sdk/+/491682 has been updated with the latest commits from this pull request. |
Extract the callee-saved register save/verify/restore logic from
Simulator::Callinto a RAIICalleeRegisterVerifierclass.Simulator::Callto 3 lines