feat: Add new fields to conversation api#1640
Conversation
3b8b13b to
cc22ce8
Compare
Signed-off-by: Javier Aliaga <javier@diagrid.io>
cc22ce8 to
c75ca06
Compare
|
/LGTM .. all green so I think we can merge this |
siri-varma
left a comment
There was a problem hiding this comment.
@javier-aliaga Quick question, should we also update/create the conversation api examples with these new fields ?
|
@siri-varma the problem is these new fields are only supported by some components but not the echo service. I modified the examples to print the usage in case the model is present. Let me work on the ResponseFormat, I would like to do a real test |
a8c2386 to
5a5d394
Compare
Signed-off-by: Javier Aliaga <javier@diagrid.io>
5a5d394 to
4517391
Compare
|
@siri-varma I modified the examples to add the new fields, bear in mind this fields only works with a real llm, no changes expected using the echo service |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1640 +/- ##
============================================
+ Coverage 79.19% 79.24% +0.04%
- Complexity 2111 2136 +25
============================================
Files 229 233 +4
Lines 6360 6437 +77
Branches 695 697 +2
============================================
+ Hits 5037 5101 +64
- Misses 971 984 +13
Partials 352 352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Add new fields for conversation api
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1639
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: