Skip to content

feat: Add new fields to conversation api#1640

Merged
dapr-bot merged 3 commits intodapr:masterfrom
javier-aliaga:update-conversation-api
Feb 6, 2026
Merged

feat: Add new fields to conversation api#1640
dapr-bot merged 3 commits intodapr:masterfrom
javier-aliaga:update-conversation-api

Conversation

@javier-aliaga
Copy link
Contributor

Description

Add new fields for conversation api

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1639

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@javier-aliaga javier-aliaga force-pushed the update-conversation-api branch 2 times, most recently from 3b8b13b to cc22ce8 Compare February 5, 2026 11:31
@javier-aliaga javier-aliaga marked this pull request as ready for review February 5, 2026 11:36
@javier-aliaga javier-aliaga requested review from a team as code owners February 5, 2026 11:36
Signed-off-by: Javier Aliaga <javier@diagrid.io>
@javier-aliaga javier-aliaga force-pushed the update-conversation-api branch from cc22ce8 to c75ca06 Compare February 5, 2026 12:21
@salaboy salaboy self-requested a review February 5, 2026 14:39
@salaboy
Copy link
Collaborator

salaboy commented Feb 5, 2026

/LGTM .. all green so I think we can merge this

salaboy
salaboy previously approved these changes Feb 5, 2026
Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javier-aliaga Quick question, should we also update/create the conversation api examples with these new fields ?

@javier-aliaga
Copy link
Contributor Author

@siri-varma the problem is these new fields are only supported by some components but not the echo service.

I modified the examples to print the usage in case the model is present.

Let me work on the ResponseFormat, I would like to do a real test

@javier-aliaga javier-aliaga force-pushed the update-conversation-api branch 7 times, most recently from a8c2386 to 5a5d394 Compare February 6, 2026 09:25
Signed-off-by: Javier Aliaga <javier@diagrid.io>
@javier-aliaga javier-aliaga force-pushed the update-conversation-api branch from 5a5d394 to 4517391 Compare February 6, 2026 09:26
@javier-aliaga
Copy link
Contributor Author

@siri-varma I modified the examples to add the new fields, bear in mind this fields only works with a real llm, no changes expected using the echo service

Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@dapr-bot dapr-bot merged commit 60f01d9 into dapr:master Feb 6, 2026
15 of 16 checks passed
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 83.75000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.24%. Comparing base (24f8b91) to head (2e17e44).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sdk/src/main/java/io/dapr/utils/ProtobufUtils.java 0.00% 11 Missing ⚠️
.../dapr/client/domain/ConversationRequestAlpha2.java 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1640      +/-   ##
============================================
+ Coverage     79.19%   79.24%   +0.04%     
- Complexity     2111     2136      +25     
============================================
  Files           229      233       +4     
  Lines          6360     6437      +77     
  Branches        695      697       +2     
============================================
+ Hits           5037     5101      +64     
- Misses          971      984      +13     
  Partials        352      352              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1.17] Add Conversation API new fields

4 participants