feat(retry): add JitterFactor to RetryPolicy#69
Open
javier-aliaga wants to merge 1 commit intodapr:mainfrom
Open
feat(retry): add JitterFactor to RetryPolicy#69javier-aliaga wants to merge 1 commit intodapr:mainfrom
javier-aliaga wants to merge 1 commit intodapr:mainfrom
Conversation
58d196b to
94c5af8
Compare
Introduce JitterFactor field to desynchronize concurrent retries using deterministic randomness (seeded by firstAttempt + attempt) for replay safety. Clamp value to [0.0, 1.0] in Validate(). Fix MaxRetryInterval comparison (was <, now >) so delay is properly capped before jitter is applied. Tests cover deterministic replay safety, delay reduction, zero-jitter passthrough, per-attempt variation, MaxRetryInterval capping, and validation clamping. Signed-off-by: Javier Aliaga <[email protected]>
94c5af8 to
bb6579b
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When orchestrations retry failed activities or sub-orchestrations, the retry delay is calculated using exponential backoff (InitialRetryInterval * BackoffCoefficient^attempt). In systems running many concurrent orchestration instances, all retries sharing the same policy configuration will compute identical delays, causing them to fire at the exact same time.
Problem
Without jitter, concurrent retries create thundering herd scenarios — all failing instances retry simultaneously, overwhelming downstream services and increasing the likelihood of repeated failures. This is a well-known distributed systems anti-pattern. Additionally, the existing computeNextDelay function had a bug where the MaxRetryInterval comparison used < instead of >, meaning the delay was never actually capped before being returned.
Solution
Add a JitterFactor field to RetryPolicy (range [0.0, 1.0]) that introduces controlled randomness to retry delays: