Open
Conversation
Collaborator
|
@zemanj this code change cannot be merged like this, vendContainer and vendDocuments serve different purposes. One for xcode installed apps and one for apps sharing their documents, vendContainer doesn't work if an app doesn't share files. If you could come up with an proposal on how to support both modes we could merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #593.
According to libimobiledevice issue 193 from 2015 (in particular, this comment), the service
com.apple.mobile.house_arrestdoesn't support theVendContainercommand anymore (unless the app was installed via XCode).However, for apps that have
UIFileSharingEnabledset totruein their information property list, theVendDocumentscommand can be used instead to access the app's/Documentsdirectory.This PR replaces
VendContainerbyVendDocumentsto make this work.Note that when using the go-iOS
fsynccommand with the option--app=BUNDLE_IDset, thePATHpassed with the option--path=PATHhas to start with/Documents(in particular,/won't work).For example, to use the
fsync treecommand for a specific app, one has to callios fsync --app=BUNDLE_ID tree --path=/Documents.