CSS refactoring + dark/light modes #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This div is only used to display the workers as stack. Setting a color for the text has no impact on the rendering.
Instead use the `text-body-tertiary` class (which is dark mode safe). We also get rid of now unused $text-color-light variable.
It was only influencing the color of the node name in the diagram. Let's use the default color.
Along the way, useless classes are removed in HTML.
We get rid of unused $padding-sm variable along the way.
Prefer boostrap classes over our own css rules.
Will be useful when adding a dark mode switcher.
This doesn't play well with a dark theme.
Replace hardcoded SCSS color variables with Bootstrap CSS variables to enable theme customization (dark mode, high contrast, branding, etc.) - Use semantic classes (bg-body, text-body-secondary, etc.) - Update hatched background pattern to use --bs-tertiary-bg - Add splitpanes theme overrides - Replace btn-light with btn-outline-secondary in PlanNode
Add theme switcher button in navbar with system preference detection. Theme preference is persisted in localStorage.
Import stackoverflow-dark theme for highlight.js when dark mode is active, scoped to [data-bs-theme="dark"] selector.
Don't use btn class, but provide a dedicated class.
We create our own tippy theme using bootstrap css variables.
pgiraud
force-pushed
the
css_refactoring
branch
from
911ddbd to
9dfa0fb
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goal is to improve CSS. It also integrates the good work done by @Alain-L in #854